Skip to content

chore: replace fast-glob with tinyglobby for Node globs#13

Merged
SutuSebastian merged 1 commit intomainfrom
chore/tinyglobby
Apr 7, 2026
Merged

chore: replace fast-glob with tinyglobby for Node globs#13
SutuSebastian merged 1 commit intomainfrom
chore/tinyglobby

Conversation

@SutuSebastian
Copy link
Copy Markdown
Contributor

@SutuSebastian SutuSebastian commented Apr 7, 2026 •
edited by coderabbitai bot
Loading

Summary

  • Swap fast-glob for tinyglobby on Node in glob-sync.ts (expandDirectories: false keeps matching aligned with previous behavior). Bun continues to use bun:Glob.
  • Add patch changeset (.changeset/tinyglobby-globs.md).
  • Update docs/architecture.md and docs/packaging.md; tsdown neverBundle lists tinyglobby.
  • CHANGELOG.md: oxfmt-only cleanup so format:check passes.

Verification

bun run check (build, format, lint, tests, typecheck, golden) passed locally.

Summary by CodeRabbit

  • Chores

    • Updated the Node.js globbing library dependency used for include-glob operations.
    • Added configuration to preserve glob-matching behavior.

  • Documentation

    • Updated architecture and packaging documentation to reflect the dependency change.

@SutuSebastian
chore: replace fast-glob with tinyglobby for Node include globs
dc7d88e 
Use tinyglobby on Node with expandDirectories: false for prior matching
behavior. Bun still uses bun:Glob. Add changeset (patch). Update packaging
and architecture docs. Format CHANGELOG with oxfmt.
@SutuSebastian SutuSebastian added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 7, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 7, 2026

🦋 Changeset detected

Latest commit: dc7d88e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@stainless-code/codemap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@SutuSebastian SutuSebastian merged commit 13a2c14 into main Apr 7, 2026
9 checks passed
@SutuSebastian SutuSebastian deleted the chore/tinyglobby branch April 7, 2026 15:28
@github-actions github-actions bot mentioned this pull request Apr 7, 2026
Merged
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 7, 2026 •
edited
Loading

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 68a503dc-0ed2-44b3-9f0a-981d75dfbff6

📥 Commits

Reviewing files that changed from the base of the PR and between f51d77f and dc7d88e.

⛔ Files ignored due to path filters (1)
  • bun.lock is excluded by !**/*.lock
📒 Files selected for processing (8)
  • .changeset/tinyglobby-globs.md
  • CHANGELOG.md
  • docs/architecture.md
  • docs/packaging.md
  • package.json
  • src/glob-sync.test.ts
  • src/glob-sync.ts
  • tsdown.config.ts
📝 Walkthrough

Walkthrough

This pull request replaces the fast-glob dependency with tinyglobby for Node.js glob pattern matching in the codemap package. Changes include updating the runtime dependency, implementation, tests, build configuration, and documentation.

Changes

Cohort / File(s) Summary
Dependency & Build Configuration
package.json, tsdown.config.ts		 Replaced fast-glob (^3.3.3) with tinyglobby (^0.2.15) in runtime dependencies and updated bundling configuration to exclude tinyglobby from the bundle.
Implementation
src/glob-sync.ts, src/glob-sync.test.ts		 Updated Node.js glob handling to use tinyglobby's globSync API with expandDirectories: false option. Test reference implementation switched from fg.sync to tinyglobbySync with matching options.
Documentation
docs/architecture.md, docs/packaging.md		 Updated documentation references to reflect the transition from fast-glob to tinyglobby in the architecture overview and packaging details.
Release Notes
.changeset/tinyglobby-globs.md, CHANGELOG.md		 Added changeset documenting the patch update with dependency replacement details; formatting cleanup in changelog spacing.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Poem

🐰 A swift hop from glob to globby we go,
Tiny paths dancing, fast-glob long ago,
Bundling configured, tests all align,
Directory expansion controlled—patterns divine!
Hop! Hop! The dependencies shine! ✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/tinyglobby

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@SutuSebastian